call user defined drop impls #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solson
suggested changes
Nov 4, 2016
| // special case `Box` to deallocate the inner allocation | ||
| // FIXME: if user defined Drop impls work, then this can go away, since the stdlib calls | ||
| // heap::deallocate | ||
| if let ty::TyBox(contents_ty) = ty.sty { |
There was a problem hiding this comment.
Merge this if let into the match below.
|
We should be able to fix this now, right? https://github.com/solson/miri/blob/master/tests/run-pass/vecs.rs#L1 |
|
In fact you can probably just |
This reverts commit 366c793.
|
indeed... reverting that commit simply worked... |
solson
approved these changes
Nov 4, 2016
erickt
pushed a commit
to erickt/miri
that referenced
this pull request
Feb 4, 2022
docs: improve badges and synopsis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.