Attempt to support to 64 lanes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
support-64-lanes
branch
from
d9f5fb8 to
267fcd5
Compare
|
While highly unscientific, this branch's test suite passes compilation on @thomcc's Apple Silicon laptop also, so I think it would be fair to go for it, here. |
|
I would add aliases for the new sizes, then lgtm. |
|
We... never actually removed the 64-lane aliases, and we've generally been following the "what aliases would make sense if the lanes were Merging. |
|
I think the vendor conversions may be missing. In particular AVX512 byte vectors lack conversions. |
|
Hm. True but also: |
|
fwiw we already accepted |
pthariensflame
added a commit
to pthariensflame/portable-simd
that referenced
this pull request
Nov 25, 2021
Resolves my comment in rust-lang#197, at least for now; rust-lang#187 is pending but since these are already here, just commented, it seemed to make sense to me to re-enable them anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can try to expand our support, and test suite, to allow
Simd<T, 64>.