Added .min and .max for integers
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebzulawski
requested changes
Mar 10, 2022
crates/core_simd/src/comparisons.rs
Outdated
| LaneCount<LANES>: SupportedLaneCount, | ||
| { | ||
| /// Returns the lane-wise minimum with other | ||
| #[must_use = "method returns a new mask and does not mutate the original value"] |
There was a problem hiding this comment.
This comment isn't quite right
|
Looks good to me other than that small comment |
|
Thank you both for the review. 🤦 Indeed. Pushed a fix to both of them. |
programmerjake
approved these changes
Mar 10, 2022
calebzulawski
approved these changes
Mar 10, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit implementations for
minandmaxfor integers.Closes #247 and rust-lang/rust#94682