Move comparisons to traits #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebzulawski
requested review from
programmerjake and
workingjubilee
and removed request for
workingjubilee
|
Apologies, I am not trying to ignore this, I just was getting sidetracked by an Adventure or two. |
|
we should post somewhere users will notice that this breaks API compatibility. |
|
Okay. Having reviewed this properly, I feel like the ergonomics of these ops could probably be improved further and I think we will eventually find we want to encode the idea of associated masking types in a separate trait, as it feels plausible masked ops will want to not have to depend on SimdPartialEq being defined, but having said that I see no reason not to merge this as it stands as it is a significant improvement. |
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simpler variant of #206.
SimdPartialEq,SimdPartialOrd, andSimdOrd. The function names are prefixed withsimd_to disambiguate from the regularPartialEqetc functions. With the functions on traits instead ofSimddirectly, shadowing the function names doesn't work very well.Ord-like functions are put into aSimdFloattrait. The intention is that eventually (some time after this PR) all floating point functions will be moved fromSimdtoSimdFloat, and the same goes for futureSimdInt/SimdUinttraits.