Canonical Paths #132
Merged
Canonical Paths #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/paths.md
Outdated
| pub struct Struct; // ::a::Struct | ||
|
|
||
| pub trait Trait { // ::a::Trait | ||
| fn f(&self); // <::a::Trait>::f |
There was a problem hiding this comment.
<::a::Trait>::f -> ::a::Trait::f.
<::a::Trait>::f has another meaning - inherent associated item on the trait object type ::a::Trait.
There was a problem hiding this comment.
I'm going with the assumption you are right, but I thought ::a::Trait::f was syntactic sugar for <::a::Trait>::f.
Havvy
force-pushed
the
follow-the-path
branch
from
4517fbc to
a45231e
Compare
src/paths.md
Outdated
| the path component the item itself defines. | ||
|
|
||
| [Implementations] and [use declarations] do not have canonical paths, although | ||
| the associated items that implementations define do have them. Items defined in |
There was a problem hiding this comment.
i wonder if "associated items" is too overloaded a term here, it made me do a double-take at first.
There was a problem hiding this comment.
It's technically extraneous, as implementations only define associated items. I removed it; does it flow better that way?
brauliobz
reviewed
Oct 14, 2017
src/paths.md
Outdated
| The path prefix for modules is the canonical path to that module. For bare | ||
| implementations, it is the canonical path of the item being implemented | ||
| surrounded by angle (`<>`) brackets. For trait implementations, it is the | ||
| cananonical path of the item being implemented followed by `as` followed by the |
There was a problem hiding this comment.
cananonical -> canonical
Havvy
force-pushed
the
follow-the-path
branch
from
a45231e to
36aee27
Compare
Havvy
force-pushed
the
follow-the-path
branch
from
36aee27 to
e675bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines canonical paths, as part of #129.
Note to reviewer(s): There's also two commits that just change the location of links and change where newlines are, so just focus on the giant green blob in the paths file.