Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue showing active FCPs in individual nags #321

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Jan 11, 2024

I'd really like to see RFCs in active final comment period that I haven't reviewed yet. Especially since now is my last chance to review them!

The current filter was originally added to address #212; I think this filter would have addressed that concern as well.

I'd really like to see RFCs in active final comment period that I haven't reviewed yet. Especially since now is my last chance to review them!

The current filter was originally added to address rust-lang#212; I think this filter would have addressed that concern as well.
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I'll merge but I think we manually deploy here so will need to find the time to do that.

@Mark-Simulacrum Mark-Simulacrum merged commit 42b8d81 into rust-lang:master Jan 11, 2024
@Mark-Simulacrum
Copy link
Member

Deployed!

@tmandry tmandry deleted the patch-1 branch January 12, 2024 02:59
@tmandry
Copy link
Member Author

tmandry commented Jan 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants