Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Do not build Clippy by default #1477

Merged
merged 2 commits into from
Jun 8, 2019
Merged

Do not build Clippy by default #1477

merged 2 commits into from
Jun 8, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jun 7, 2019

For rust-lang/rust#59761

As the bonus I changed Travis to test Clippy only when commit message contains words update, clippy. You can see it in the action here: https://travis-ci.com/mati865/rls/builds/114715073 https://travis-ci.com/mati865/rls/builds/114715514
That trick was borrowed from Rust: https://github.com/rust-lang/rust/blob/ca1bcfdde3f19afd68ef808cecf2ce56d08d5df4/.travis.yml#L218

@Xanewok
Copy link
Member

Xanewok commented Jun 7, 2019

(...) only when commit message contains words update

That does seem fragile - ideally we'd rebuild whenever resolved clippy_lints rev changes in Cargo.toml but let's land that as-is

@mati865
Copy link
Contributor Author

mati865 commented Jun 7, 2019

ideally we'd rebuild whenever resolved clippy_lints rev changes in Cargo.toml

With some trickery involved it'd possible to make Clippy job always run and return early if clippy_lints line hasn't changed.

@mati865
Copy link
Contributor Author

mati865 commented Jun 7, 2019

Rebased on 7ec4b12

@alexheretic
Copy link
Member

Good idea! Clippy is a real pain for rls development/ci at the moment.

@Xanewok Xanewok merged commit a2dcd69 into rust-lang:master Jun 8, 2019
@mati865 mati865 deleted the clippy branch June 8, 2019 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants