Skip to content

Commit

Permalink
Downgrade @types/node
Browse files Browse the repository at this point in the history
  • Loading branch information
lnicola committed Jun 28, 2020
1 parent 9ef4e85 commit 5d783a2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions editors/code/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion editors/code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@rollup/plugin-node-resolve": "^8.1.0",
"@types/glob": "^7.1.2",
"@types/mocha": "^7.0.2",
"@types/node": "^14.0.14",
"@types/node": "^12.8.1",

This comment has been minimized.

Copy link
@Veetaha

Veetaha Jun 28, 2020

Contributor

This will still use the latest minor version of @types/node due to ^ wildcard. Looking at the diff in package-lock.json we can see this. Btw, vscode-insiders already uses nodejs v12.13.0
I'd propose to make it 12.12.x (there is no @types/node 12.13 version published yet)

"@types/node-fetch": "^2.5.7",
"@types/vscode": "^1.44.1",
"@typescript-eslint/eslint-plugin": "^3.4.0",
Expand Down

0 comments on commit 5d783a2

Please sign in to comment.