-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive the librarification effort #15569
Comments
First thing to do is adding the toggle mentioned in #14846 to switch to the workspace dependencies for rustc crate when r-a is being built inside of the rustc tree, so things like rust-lang/rust#107163 will be detected in the rustc CI. For I'm all for librarification, in any shape. It seems like out of tree librarification (like chalk and polonious) made things hard for rustc developers, and in tree librarification (like rustc_lexer) is the way to go, which that toggle can help with it. About |
With toggle you mean the Having them synced properly is orthogonal to this issue. It's mainly about the crates being usable on a stable context such other consumers (which r-a is a prime example of) can use them. |
Our fork of
rustc_abi
is quite outdated by now, and unfortunately upstream broke the non nightly build of it (and worse, removed all the generic parameters we depended on) so we can't update it anymore without putting in significant effort into fixing that. This will most likely be a recurring thing so maybe it is time to revive the librarification effort (and potentially crate a working group for that) to lay out a proper plan for such crates. Or at least properly librarify the rustc_abi crate (that is no ugly nightly cfgs)Obviously not the best place to have this discussion right now, but putting it down here as a reminder (to myself at least).
The text was updated successfully, but these errors were encountered: