Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid two-phase borrow conflict #1121

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Apr 8, 2019

@matklad
Copy link
Member

matklad commented Apr 8, 2019

bors r+

Can we somehow enable this lint? Or is it nightly-only for now?

bors bot added a commit that referenced this pull request Apr 8, 2019
1121: Avoid two-phase borrow conflict r=matklad a=lnicola

See rust-lang/rust#59159.

Co-authored-by: Laurențiu Nicola <[email protected]>
@lnicola
Copy link
Member Author

lnicola commented Apr 8, 2019

It's nightly-only. It might be a good idea to add nightly to CI while allowing failures, just to catch the odd case like this.

@bors
Copy link
Contributor

bors bot commented Apr 8, 2019

Build succeeded

@bors bors bot merged commit 61c09ed into rust-lang:master Apr 8, 2019
@lnicola lnicola deleted the avoid-2pb-conflict branch April 8, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants