Remove deprecate action #12764
Remove deprecate action #12764
Conversation
.github/workflows/ci.yaml
Outdated
| profile: minimal | ||
| override: true | ||
| components: rustfmt, rust-src | ||
| run: rustup update stable && rustup component add rustfmt rust-src |
There was a problem hiding this comment.
This no longer uses the minimal profile, so it downloads rust-docs, clippy, ...
There was a problem hiding this comment.
I would expect rustup update stable to be no-op most of the time
There was a problem hiding this comment.
We could also rustup component remove rust-docs clippy, but then we pay that cost every time on Windows, not only when the GHA image lags.
|
I don't understand the error and the warnings. Does it have a non- |
|
I think its windows being confused by |
|
I don't think so, it works AFAIK and it failed again even with It might be |
https://old.reddit.com/r/rust/comments/vyx4oj/actionsrs_organization_became_unmaintained/ Looking at this holistically, I don't fully understand *why* we need an action here? Seems like we can just use rustup? nowadays github runners come with rustup pre-installed.
Co-authored-by: Laurențiu Nicola <[email protected]>
https://old.reddit.com/r/rust/comments/vyx4oj/actionsrs_organization_became_unmaintained/ Looking at this holistically, I don't fully understand *why* we need an action here? Seems like we can just use rustup? nowadays github runners come with rustup pre-installed.
|
r? @lnicola |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
This seems to cause spurious CI failures now? https://github.com/rust-lang/rust-analyzer/runs/7369572106?check_suite_focus=true From the looks of it, the windows target always fails once now, requiring a |
|
Ah, so it non-deterministicaly fails? Huh, this makes it even curiouser. |
|
So far I observed this on 2 out of 2 PRs, let's see if the same happens in #12773 |
|
Lets see if #12776 fixes it |
|
Possibly related: rust-lang/rustup#3029. |
https://old.reddit.com/r/rust/comments/vyx4oj/actionsrs_organization_became_unmaintained/
Looking at this holistically, I don't fully understand why we need an
action here? Seems like we can just use rustup? nowadays github runners
come with rustup pre-installed.