Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command for manually running flychecks #13785

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Add command for manually running flychecks #13785

merged 1 commit into from
Dec 16, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 16, 2022

Closes #13125

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2022
@Veykril
Copy link
Member Author

Veykril commented Dec 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 16, 2022

📌 Commit a04feb9 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 16, 2022

⌛ Testing commit a04feb9 with merge e0aa5af...

@bors
Copy link
Contributor

bors commented Dec 16, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e0aa5af to master...

@bors bors merged commit e0aa5af into rust-lang:master Dec 16, 2022
@bors bors mentioned this pull request Dec 16, 2022
Closed
@flodiebold
Copy link
Member

flodiebold commented Dec 19, 2022 •
edited
Loading

We should probably not call it "Flycheck" for the user, how about just Run check?

@Veykril Veykril deleted the run-flycheck branch December 19, 2022 15:21
@Veykril
Copy link
Member Author

Veykril commented Dec 19, 2022 •
edited
Loading

I agree that flycheck isn't the best fit, but check seems really generic so I am not sure if its apparent what check necessarily means for people when they read it for the first time either? I guess Run cargo check would be better? (shame we can't have the command label be dynamic).

Alternatively we can start pushing the flycheck term so that people know what it means. After adding this I was thinking of maybe changing the name of checkOnSave configs to check, flycheck, etc since it's no longer only tied to saving

@ian-h-chamberlain ian-h-chamberlain mentioned this pull request Mar 24, 2023
Open
@LennyLizowzskiy LennyLizowzskiy mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Command to run check/clippy without saving
4 participants
@Veykril @bors @flodiebold @rustbot