fix: Fix related documents diagnostics #18519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were converted to LSP position using the current file's line index, which is obviously wrong.
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Nov 17, 2024
|
Ouch, this might warrant another beta backport. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were converted to LSP position using the current file's line index, which is obviously wrong.
I'm not sure how to test this since that require an entire operating r-a, since the functionality is in the rust-analyzer crate. I verified manually that this works.
The problem was introduced in #18404. Oopsie :)
Fixes #18513.