Support assignment to FieldExpr for extract_assignment assist #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Jan 3, 2021
|
@matklad I was thinking that it may be nicer to compare the paths with |
Jesse-Bakker
force-pushed
the
extract-assignment-fields
branch
from
e5f76f6 to
38d914a
Compare
|
@Jesse-Bakker I think that the right solution might be comparing I think we need to extract fn is_equivalent(sema: &Semantics, e1: &ast::Expr, e2: &ast::Expr) -> booland then tweak the impl as we go forward |
Jesse-Bakker
force-pushed
the
extract-assignment-fields
branch
2 times, most recently
from
79f26bb to
0477de9
Compare
Jesse-Bakker
force-pushed
the
extract-assignment-fields
branch
from
0477de9 to
ba4c42a
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.