-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 0.30.0 #935
Conversation
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
From the test output, the stable rust side is still emitting BindgenUnion(https://github.com/rust-lang-nursery/rust-bindgen/blob/master/tests/expectations/tests/anon_struct_in_union_1_0.rs) |
Those are testing Rust 1.0 output. Anyway, doing a new release sounds fine to me, @fitzgen, any reason we shouldn't? |
Did stylo folks end up making their own bug-fix-only branch yet? I see no reason not to release a 0.30.0 crate. |
@bors-servo r+
|
📌 Commit 3cbdb98 has been approved by |
@emilio I'll write release notes and publish to crates.io if you haven't already |
I planned to do so when it merges, but feel free to :) |
Both release notes and publishing, or just the latter? |
Mostly publishing. If you could do relnotes that'd be awesome, because it's taking a bit and I'm about to head out. |
Sure thing |
☀️ Test successful - status-travis |
0.30.0 is published |
And release notes published on r/rust and u.r-l.o |
Version bump, primarily to get #832 and #892 in now that 1.19 is out and untagged unions are usable in stable!
r? @emilio