This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Backfill MAJOR.MINOR Rustup channel manifests #949
Closed
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that rust-lang/rust#76107 has been merged, new releases will also write their manifests to channel-rust-1.x.toml as well as channel-rust-1.x.y.toml to enable `rustup install 1.48` to get the latest patch release in a minor release series. This commit adds an idempotent function to copy manifests for the last patch release in every minor release series to the corresponding minor manifest so that past minor versions will work with the rustup functionality too. This function should only need to be run once, but should be safe to run more than once.
|
This is missing I'm wondering if this can be turned into a script we can run locally with AWS credentials, instead of always doing it in the release process. |
|
Yep, I can do that! Going to close this in the meantime :) Thank you for the feedback! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rust-lang/rust#76107 has been merged,
new releases will also write their manifests to channel-rust-1.x.toml as
well as channel-rust-1.x.y.toml to enable
rustup install 1.48to getthe latest patch release in a minor release series.
This commit adds an idempotent function to copy manifests for the last
patch release in every minor release series to the corresponding
minor manifest so that past minor versions will work with the rustup
functionality too.
This function should only need to be run once, but should be safe to run
more than once.
r? @pietroalbini or @Mark-Simulacrum