Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect fix for uninlined_format_args with unicode character #9727

Closed
cgzones opened this issue Oct 26, 2022 · 0 comments · Fixed by rust-lang/rust#103651
Closed

Incorrect fix for uninlined_format_args with unicode character #9727

cgzones opened this issue Oct 26, 2022 · 0 comments · Fixed by rust-lang/rust#103651
Assignees
@Alexendoo
Labels
C-bug Category: Clippy is not doing the correct thing I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied

Comments

@cgzones
Copy link

cgzones commented Oct 26, 2022 •
edited
Loading

Summary

Nightly clippy fixes ``uninlined_format_args` incorrectly when a unicode character is involved:

Reproducer

I tried this code (https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=795eeb30bacb8129ad8b2d07cfd2703c):

pub fn foo() {
    let a = "a";
    let b = "b";

    println!("{}\u{2794}{}", a, b);
}
warning: variables can be used directly in the `format!` string
 --> src/lib.rs:5:5
  |
5 |     println!("{}\u{2794}{}", a, b);
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
  = note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
  |
5 -     println!("{}\u{2794}{}", a, b);
5 +     println!("{a}\u{2794}{}"b, a);
  |

warning: `playground` (lib) generated 1 warning

Version

rustc 1.66.0-nightly (bed4ad65b 2022-10-25)
binary: rustc
commit-hash: bed4ad65bf7a1cef39e3d66b3670189581b3b073
commit-date: 2022-10-25
host: x86_64-unknown-linux-gnu
release: 1.66.0-nightly
LLVM version: 15.0.2

Additional Labels

No response
@cgzones cgzones added the C-bug Category: Clippy is not doing the correct thing label Oct 26, 2022
@Alexendoo Alexendoo added the I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied label Oct 27, 2022
@Alexendoo Alexendoo self-assigned this Oct 27, 2022
@Alexendoo Alexendoo mentioned this issue Oct 27, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 7, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103651 - Alexendoo:parse-format-unicode-esc…
8e0a7a8 
…apes, r=wesleywiser

Fix `rustc_parse_format` spans following escaped utf-8 multibyte chars

Currently too many skips are created for char escapes that are larger than 1 byte when encoded in UTF-8, [playground:](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c77a9dc669b69b167271b59ed2c8d88c)

```rust
fn main() {
    format!("\u{df}{a}");
    format!("\u{211d}{a}");
    format!("\u{1f4a3}{a}");
}
```
```
error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `a` in this scope
 --> src/main.rs:2:22
  |
2 |     format!("\u{df}{a}");
  |                      ^ not found in this scope

error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `a` in this scope
 --> src/main.rs:3:25
  |
3 |     format!("\u{211d}{a}");
  |                         ^ not found in this scope

error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `a` in this scope
 --> src/main.rs:4:27
  |
4 |     format!("\u{1f4a3}{a}");
  |                           ^ not found in this scope
```

This reduces the number of skips to account for that

Fixes rust-lang/rust-clippy#9727
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 7, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103651 - Alexendoo:parse-format-unicode-esc…
591c3d6 
…apes, r=wesleywiser

Fix `rustc_parse_format` spans following escaped utf-8 multibyte chars

Currently too many skips are created for char escapes that are larger than 1 byte when encoded in UTF-8, [playground:](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c77a9dc669b69b167271b59ed2c8d88c)

```rust
fn main() {
    format!("\u{df}{a}");
    format!("\u{211d}{a}");
    format!("\u{1f4a3}{a}");
}
```
```
error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `a` in this scope
 --> src/main.rs:2:22
  |
2 |     format!("\u{df}{a}");
  |                      ^ not found in this scope

error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `a` in this scope
 --> src/main.rs:3:25
  |
3 |     format!("\u{211d}{a}");
  |                         ^ not found in this scope

error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `a` in this scope
 --> src/main.rs:4:27
  |
4 |     format!("\u{1f4a3}{a}");
  |                           ^ not found in this scope
```

This reduces the number of skips to account for that

Fixes rust-lang/rust-clippy#9727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexendoo Alexendoo

Labels
C-bug Category: Clippy is not doing the correct thing I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rustc_parse_format spans following escaped utf-8 multibyte chars Alexendoo/rust
2 participants
@Alexendoo @cgzones