Add size_of_ref lint #10098
Merged
Add size_of_ref lint #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #10099) made this pull request unmergeable. Please resolve the merge conflicts. |
lukaslueg
force-pushed
the
size_of_ref
branch
from
9a8fba7 to
4826743
Compare
|
☔ The latest upstream changes (presumably #10063) made this pull request unmergeable. Please resolve the merge conflicts. |
lukaslueg
force-pushed
the
size_of_ref
branch
from
4826743 to
8b36c80
Compare
Jarcho
reviewed
Dec 23, 2022
Jarcho
reviewed
Dec 24, 2022
|
Ah sorry, I was lazy :-/ Will squash if needed |
lukaslueg
force-pushed
the
size_of_ref
branch
from
4cacc4f to
eac3349
Compare
|
It's better if it's squashed, but not a big deal. |
lukaslueg
force-pushed
the
size_of_ref
branch
from
eac3349 to
d7b9e19
Compare
|
squashed |
|
Thank you. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #9995, which is likely raising a valid point about
std::mem::size_of_val(): It's very easy to use double-references as the argument, which the function will happily accept and give back the size of the reference, not the size of the value behind the reference. In the worst case, if the value matches the programmer's expectation, this seems to work, while in fact, everything will go horribly wrong e.g. on a different platform.The size of a
&Tis independent of whatTis, and people might want to usestd::mem::size_of_val()to actually get the size of any reference (e.g. via&&()). I would rather suggest that this is always bad behavior, though (instead, and). I, therefore, put this lint intocorrectness.Since the problem is usually easily fixed by removing extra
&, I went light on suggesting code.changelog: New lint: [
size_of_ref]#10098