-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope missing_docs_in_private_items
to only private items
#10324
Scope missing_docs_in_private_items
to only private items
#10324
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) soon. Please see the contribution instructions for more information. |
missing_docs_in_private_items
to only private items
4599470
to
a1c2039
Compare
☔ The latest upstream changes (presumably #10303) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewbanchich Thanks for the PR! and sorry for the delay in reviewing.
The change itself looks good. I'd say that this is not an internal-only change, so adding a changelog in the PR description is a good idea (so it will also be reflected in the changelog).
Otherwise, just a small nit/question
d96d832
to
74880ca
Compare
☔ The latest upstream changes (presumably #10401) made this pull request unmergeable. Please resolve the merge conflicts. |
74880ca
to
49a06ed
Compare
@dswij Fixed some more conflicts with work others are doing. Everything should be addressed now. |
Thanks for this! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
missing_docs_in_private_items
currently detects missing docs for public items as well as private. Sincemissing_docs
already covers public items, this PR updatesmissing_docs_in_private_items
to only cover private items.Fixes #1895
changelog: [
missing_docs_in_private_items
]: Apply lint only to private items (used to be public and private)