Extend explicit_iter_loop and explicit_into_iter_loop
#10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
explicit_iter_loop_ext
branch
3 times, most recently
from
171a5a8 to
cd21cf7
Compare
|
☔ The latest upstream changes (presumably #10350) made this pull request unmergeable. Please resolve the merge conflicts. |
Jarcho
force-pushed
the
explicit_iter_loop_ext
branch
from
cd21cf7 to
45a2958
Compare
|
ping @Manishearth |
Jarcho
force-pushed
the
explicit_iter_loop_ext
branch
2 times, most recently
from
0b24607 to
d107146
Compare
Jarcho
force-pushed
the
explicit_iter_loop_ext
branch
from
d107146 to
949712c
Compare
Manishearth
reviewed
Jun 12, 2023
| use rustc_span::symbol::sym; | ||
|
|
||
| #[derive(Clone, Copy)] | ||
| enum AdjustKind { |
There was a problem hiding this comment.
sugestion: would it be possible to make these adjustkind APIs generally useful in utils?
There was a problem hiding this comment.
I'm not sure how much can be pulled out. Every time I've had to handle adjustments there's always been some weird cases to handle. Something I'll keep in mind to do if it ever comes up.
Manishearth
approved these changes
Jun 12, 2023
|
@bors r=Manishearth |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1518
Some included cleanups
for_looptest into different files for each lint (partially).into_itercases fromexplicit_into_iter.changelog: Enhancement: [
explicit_iter_loop]: Now also handles types that implementIntoIterator.#10416
changelog: Sugg: [
explicit_into_iter_loop]: The suggestion now works on mutable references.#10416