Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: drop serde feature from url, drop rustc-workspace-hack #10824

Merged
merged 2 commits into from
May 30, 2023

Conversation

klensy
Copy link
Contributor

@klensy klensy commented May 25, 2023

Cargo now have it's own workspace and rustc dropped rustc-workspace-hack, so no need to unify features here; drop rustc-workspace-hack.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 25, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 25, 2023
@flip1995
Copy link
Member

rustc dropped rustc-workspace-hack

Can you link to the PR that did this, please?

@klensy
Copy link
Contributor Author

klensy commented May 25, 2023

rustc dropped rustc-workspace-hack

Can you link to the PR that did this, please?

Added link to first message.

@klensy klensy changed the title deps: drop serde feature from url deps: drop serde feature from url, drop rustc-workspace-hack May 25, 2023
@klensy
Copy link
Contributor Author

klensy commented May 25, 2023

Ow, actually can drop rustc-workspace-hack too, thanks for suggestion.

@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Contributor

bors commented May 30, 2023

📌 Commit 066037b has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 30, 2023

⌛ Testing commit 066037b with merge 423f081...

@bors
Copy link
Contributor

bors commented May 30, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 423f081 to master...

@bors bors merged commit 423f081 into rust-lang:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants