Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let_and_return: lint 'static lifetimes, don't lint borrows in closures #11061

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

Alexendoo
Copy link
Member

Fixes #11056

Now also ignores functions returning 'static lifetimes, since I noticed the stdin.lock() example was still being linted but doesn't need to be since rust-lang/rust#93965

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 2, 2023
@Alexendoo Alexendoo force-pushed the let-and-return-closures branch from fbe9a68 to e29a5ac Compare July 2, 2023 14:25
@llogiq
Copy link
Contributor

llogiq commented Jul 2, 2023

Thank you, LGTM.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 2, 2023

📌 Commit e29a5ac has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 2, 2023

⌛ Testing commit e29a5ac with merge 83d0682...

@bors
Copy link
Contributor

bors commented Jul 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 83d0682 to master...

@bors bors merged commit 83d0682 into rust-lang:master Jul 2, 2023
@Alexendoo Alexendoo deleted the let-and-return-closures branch July 2, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo clippy attempted to fix let_and_return but failed
4 participants