[new_without_default]: include where clause in suggestions, make applicable
#11280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #11239) made this pull request unmergeable. Please resolve the merge conflicts. |
The comment was likely obsolete.
Now that generics and lifetimes are output as expected, the lint should be applicable.
samueltardieu
force-pushed
the
issue-11267
branch
from
5be4dc9 to
f9b22e7
Compare
|
r? @Centri3 |
Centri3
approved these changes
Aug 18, 2023
|
Don't see any issue with making this applied by default. @bors r+ |
bors
added a commit
that referenced
this pull request
Aug 18, 2023
[new_without_default]: include `where` clause in suggestions, make applicable [`new_without_default`]: include `where` clause in suggestions
|
💔 Test failed - checks-action_test |
|
Didn't have @bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11267
changelog: [
new_without_default]: includewhereclause in suggestions