Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message to manual_inspect lint #13006

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

flip1995
Copy link
Member

r? @Jarcho

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 28, 2024
@y21 y21 linked an issue Jun 28, 2024 that may be closed by this pull request
@Jarcho
Copy link
Contributor

Jarcho commented Jun 28, 2024

@bors r+

I don't know why anybody would want error messages.

@bors
Copy link
Contributor

bors commented Jun 28, 2024

📌 Commit 01a6dfa has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 28, 2024

⌛ Testing commit 01a6dfa with merge 1aa236d...

@bors
Copy link
Contributor

bors commented Jun 28, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 1aa236d to master...

@bors bors merged commit 1aa236d into rust-lang:master Jun 28, 2024
8 checks passed
@RalfJung
Copy link
Member

I don't know why anybody would want error messages.

I honestly can't tell if you are joking...
but in case you are not: it is very confusing to have an error that just says "error". It basically says "something is wrong with your code" but then it doesn't tell me what is wrong with my code, which is something between confusing and irritating.

@Jarcho
Copy link
Contributor

Jarcho commented Jun 30, 2024

I'm not sure if that could have been less serious. I figured the approval in the same comment would be enough of an indicator.

@RalfJung
Copy link
Member

RalfJung commented Jun 30, 2024

Without any non-verbal cues, interpreting text messages on the internet is very tricky, which is why it is customary to indicate jokes textually, such as with a smiley: ";)". Without such an indication, I think you are expecting too much from random people on the internet being able to read your thoughts. The approval in the same message could easily also have meant " 🤷 but the PR also doesn't hurt so whatever, let's just land it".

Communication among strangers is hard even when tons of explicit cues are given. Let's not make it harder than necessary. :)

@flip1995 flip1995 deleted the manual-inspect-error-message branch July 1, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_inspect does not have an error message
5 participants