-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [extern_without_abi
] lint
#13404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me 👍
☔ The latest upstream changes (presumably #13322) made this pull request unmergeable. Please resolve the merge conflicts. |
faebef5
to
5cf2faf
Compare
☔ The latest upstream changes (presumably #13440) made this pull request unmergeable. Please resolve the merge conflicts. |
5cf2faf
to
515cc2b
Compare
Thank you for reviewing the PR. It should include the changes you requested. I went ahead and squashed and merged the changes with the latest from master. |
☔ The latest upstream changes (presumably #13334) made this pull request unmergeable. Please resolve the merge conflicts. |
515cc2b
to
7df214f
Compare
☔ The latest upstream changes (presumably #13395) made this pull request unmergeable. Please resolve the merge conflicts. |
7df214f
to
f81518a
Compare
f81518a
to
b7c4490
Compare
In addition to fixing the merge conflicts, I moved |
There's the |
I guess There is one difference, this lint emits a diagnostic with a suggestion. I don't believe |
Fixes #13372
The [
extern_without_abi
] lint emits whenextern
is not followed by an ABI. For example:changelog: Add [
extern_without_abi
] lint