Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version for ref_option #13569

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix version for ref_option #13569

merged 1 commit into from
Oct 20, 2024

Conversation

alex-semenyuk
Copy link
Member

Close #13566
As mentioned at #13566 ref_option was merged after 1.82.0 so it wasn't include in this version

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 20, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and it indeed is not available. Thanks for the contribution, LGTM! ❤️

@blyxyas
Copy link
Member

blyxyas commented Oct 20, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2024

📌 Commit 64c4cf1 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 20, 2024

⌛ Testing commit 64c4cf1 with merge d00ab2e...

@bors
Copy link
Contributor

bors commented Oct 20, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing d00ab2e to master...

@bors bors merged commit d00ab2e into rust-lang:master Oct 20, 2024
8 checks passed
@ShakenCodes
Copy link

The fix is flawed... as the website is reporting the lint as available in Rust 1.83.0, but Clippy for release 1.83.0 reports "error: unknown lint: clippy::ref_option"

@alex-semenyuk
Copy link
Member Author

Accordance changes rust-1.82.0...rust-1.83.0 this is appeared at 1.83.0

@ShakenCodes
Copy link

Accordance changes rust-1.82.0...rust-1.83.0 this is appeared at 1.83.0

My bad... the compilation that failed had a flag causing it to select an older nightly compiler. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref_option is not available in stable 1.82.0
5 participants