-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix #1928 #1929
Try to fix #1928 #1929
Conversation
Thank you! |
This broke dogfood. I've fixed it on master. Strange that CI did not catch it. No worries, just wanted to let you know that a little |
@llogiq Ah, sorry. I though I only needed to run |
We have https://github.com/rust-lang-nursery/rust-clippy/blob/master/CONTRIBUTING.md but it should probably also state that |
As I said, no worries, I caught it quickly, and I haven't made a release yet anyway (CI is still acting up, and I have to fix lunch for my family). @oli-obk can you take it from here? I won't have much time during the next hours. |
Oh that was me. I changed Travis rules so we wouldn't build both the branch and the PR, but still built the master branch once a day. I changed it back so branches are built again |
Any chance this would get a update on crates.io? Clippy is currently broken for me (v0.0.148) and this seems to fix it. |
I won't get to it today, but it'll be the first thing I'll do on monday |
I just published. |
I could however not add the 0.0.149 tag due to my GPG key not yet being on this system. 🙁 Ah, well, I'll leave it to @oli-obk to add the tag tomorrow. |
done |
Thank you! |
Everything works again, thanks! |
Hope this is the correct way to fix it as I have completely no ideas about the floating points.
Fixes #1928