Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix #1928 #1929

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Try to fix #1928 #1929

merged 1 commit into from
Aug 6, 2017

Conversation

Frederick888
Copy link
Contributor

@Frederick888 Frederick888 commented Aug 6, 2017

Hope this is the correct way to fix it as I have completely no ideas about the floating points.

Fixes #1928

@llogiq llogiq merged commit 4bb2d61 into rust-lang:master Aug 6, 2017
@llogiq
Copy link
Contributor

llogiq commented Aug 6, 2017

Thank you!

@llogiq
Copy link
Contributor

llogiq commented Aug 6, 2017

This broke dogfood. I've fixed it on master. Strange that CI did not catch it. No worries, just wanted to let you know that a little cargo test before pushing that PR can work wonders 😉

@Frederick888
Copy link
Contributor Author

@llogiq Ah, sorry. I though I only needed to run cargo test examples. I remember that there is a list of todos before PR somewhere but I cannot find it now. Do you know where it is?

@oli-obk
Copy link
Contributor

oli-obk commented Aug 6, 2017

We have https://github.com/rust-lang-nursery/rust-clippy/blob/master/CONTRIBUTING.md but it should probably also state that cargo test should be run ^^

@llogiq
Copy link
Contributor

llogiq commented Aug 6, 2017

As I said, no worries, I caught it quickly, and I haven't made a release yet anyway (CI is still acting up, and I have to fix lunch for my family). @oli-obk can you take it from here? I won't have much time during the next hours.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 6, 2017

Oh that was me. I changed Travis rules so we wouldn't build both the branch and the PR, but still built the master branch once a day. I changed it back so branches are built again

@Thomasdezeeuw
Copy link
Contributor

Any chance this would get a update on crates.io? Clippy is currently broken for me (v0.0.148) and this seems to fix it.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 6, 2017

I won't get to it today, but it'll be the first thing I'll do on monday

@llogiq
Copy link
Contributor

llogiq commented Aug 6, 2017

I just published.

@llogiq
Copy link
Contributor

llogiq commented Aug 6, 2017

I could however not add the 0.0.149 tag due to my GPG key not yet being on this system. 🙁 Ah, well, I'll leave it to @oli-obk to add the tag tomorrow.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 7, 2017

done

@llogiq
Copy link
Contributor

llogiq commented Aug 7, 2017

Thank you!

@Thomasdezeeuw
Copy link
Contributor

Everything works again, thanks!

@Frederick888 Frederick888 deleted the fix-1928 branch September 23, 2017 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build with rustc 1.21.0-nightly (ed16b0a1d 2017-08-05)
4 participants