Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention S-inactive-closed PRs in the CONTRIBUTING.md #3589

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

flip1995
Copy link
Member

Some of these PRs would be great if they could be completed. But I guess no-one would look through closed PRs if they want to contribute. Let's point (new) contributors there by mentioning these PRs in the CONTRIBUTING.md

@phansch
Copy link
Member

phansch commented Dec 27, 2018

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Dec 27, 2018

📌 Commit b5e545a has been approved by phansch

@bors
Copy link
Contributor

bors commented Dec 27, 2018

⌛ Testing commit b5e545a with merge dfe1232...

bors added a commit that referenced this pull request Dec 27, 2018
Mention S-inactive-closed PRs in the CONTRIBUTING.md

Some of these PRs would be great if they could be completed. But I guess no-one would look through closed PRs if they want to contribute. Let's point (new) contributors there by mentioning these PRs in the `CONTRIBUTING.md`
@bors
Copy link
Contributor

bors commented Dec 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing dfe1232 to master...

@bors bors merged commit b5e545a into rust-lang:master Dec 27, 2018
@flip1995 flip1995 deleted the contrib_inactive_prs branch December 27, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants