Deprecate unused_collect lint #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
commented
Aug 7, 2019
phansch
added
the
S-waiting-on-author
phansch
force-pushed
the
deprecate-unused-unused-collect
branch
from
6fd72cb to
beadfd4
Compare
phansch
removed
the
S-waiting-on-author
phansch
force-pushed
the
deprecate-unused-unused-collect
branch
from
beadfd4 to
2aa71a8
Compare
phansch
added
the
S-blocked
|
Blocking this on #4349 |
phansch
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #4368) made this pull request unmergeable. Please resolve the merge conflicts. |
phansch
removed
the
S-blocked
phansch
force-pushed
the
deprecate-unused-unused-collect
branch
from
2aa71a8 to
ed1f384
Compare
I found this because we only had two test cases in total for this lint. It turns out the functionality is fully covered by rustc these days. [Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4) changelog: Deprecate `unused_collect` lint. This is fully covered by rustc's `#[must_use]` on `collect` cc rust-lang#2846
phansch
force-pushed
the
deprecate-unused-unused-collect
branch
from
ed1f384 to
42f0353
Compare
phansch
added
S-waiting-on-review
|
That should be ready now. @bors r+ |
|
📌 Commit 42f0353 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 15, 2019
…1995 Deprecate unused_collect lint I found this because we only had two test cases in total for this lint. It turns out the functionality is fully covered by rustc these days. [Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4) changelog: Deprecate `unused_collect` lint. This is fully covered by rustc's `#[must_use]` on `collect` cc #2846
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.
Playground Examples
changelog: Deprecate
unused_collectlint. This is fully covered by rustc's#[must_use]oncollectcc #2846