Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import rustc_plugin from its new location #4416

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

SimonSapin
Copy link
Contributor

Depends on rust-lang/rust#62727

changelog: none

@phansch
Copy link
Member

phansch commented Aug 20, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Aug 20, 2019

📌 Commit 08d8ffc has been approved by phansch

@bors
Copy link
Contributor

bors commented Aug 20, 2019

⌛ Testing commit 08d8ffc with merge b1d735d...

bors added a commit that referenced this pull request Aug 20, 2019
Import rustc_plugin from its new location

Depends on rust-lang/rust#62727

changelog: none
@bors
Copy link
Contributor

bors commented Aug 20, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented Aug 20, 2019

The RLS integration failed because.. it needs to be updated to a Clippy version that contains this Clippy PR.

Since everything else passed, I'm going to merge this PR manually and file a rls PR.

@phansch phansch merged commit 1055cf5 into rust-lang:master Aug 20, 2019
bors added a commit that referenced this pull request Aug 20, 2019
Disable RLS integration test

until RLS has been updated to the latest Clippy commit.

cc #4416 (comment)

changelog: none
@SimonSapin SimonSapin deleted the plugin branch August 20, 2019 15:15
@SimonSapin
Copy link
Contributor Author

I thought rust-lang/rust#62727 was not in Nightly yet?

@tesuji
Copy link
Contributor

tesuji commented Aug 20, 2019

We use master rustc, not nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants