Add lint for float in array comparison #5345

marcin-serwin · 2020-03-20T11:34:30Z

Fixes #4277
changelog:

Added new handler for expression of index kind (e.g. arr[i]). It returns a constant when both array and index are constant, or when the array is constant and all values are equal.
Trigger float_cmp and float_cmp_const lint when comparing arrays. Allow for comparison when one of the arrays contains only zeros or infinities.
Added appropriate tests for such cases.

flip1995 · 2020-03-30T17:40:48Z

@yaahc I already left a review for this in #4343, which was closed in favor of this.

yaahc

lgtm

tests/ui/float_cmp.stderr

marcin-serwin · 2020-04-06T07:55:35Z

Hi @flip1995,
I don't know what these two new checks are and there is no info on why they fail. Could you offer some help?

flip1995 · 2020-04-06T10:39:32Z

It's a GHA bug, that will hopefully be fixed today/soon. So don't worry about it

marcin-serwin · 2020-04-06T10:54:01Z

I've made the changes requested in conversations, so this PR can be reviewed again.

tests/ui/float_cmp.stderr

clippy_lints/src/misc.rs

flip1995 · 2020-04-06T13:31:48Z

Thanks! Waiting for GHA to get fixed.

flip1995 · 2020-04-06T13:40:52Z

@Toxyxer you have to run

tests/ui/update-references.sh 'target/debug/test_build_base' 'float_cmp.rs'

again

marcin-serwin · 2020-04-06T13:45:23Z

Sorry, I forgot about the second change :>

flip1995 · 2020-04-07T18:11:37Z

@bors r+ rollup

bors · 2020-04-07T18:11:38Z

📌 Commit 4348af2 has been approved by flip1995

bors · 2020-04-07T18:11:39Z

🌲 The tree is currently closed for pull requests below priority 2, this pull request will be tested once the tree is reopened

…comparison, r=flip1995 Add lint for float in array comparison Fixes rust-lang#4277 changelog: - Added new handler for expression of index kind (e.g. `arr[i]`). It returns a constant when both array and index are constant, or when the array is constant and all values are equal. - Trigger float_cmp and float_cmp_const lint when comparing arrays. Allow for comparison when one of the arrays contains only zeros or infinities. - Added appropriate tests for such cases.

@ghost

Rollup of 12 pull requests Successful merges: - #5345 (Add lint for float in array comparison) - #5406 (Fix update_lints) - #5409 (Downgrade let_unit_value to pedantic) - #5410 (Downgrade trivially_copy_pass_by_ref to pedantic) - #5412 (Downgrade inefficient_to_string to pedantic) - #5415 (Add new lint for `Result<T, E>.map_or(None, Some(T))`) - #5417 (Update doc links and mentioned names in docs) - #5419 (Downgrade unreadable_literal to pedantic) - #5420 (Downgrade new_ret_no_self to pedantic) - #5422 (CONTRIBUTING.md: fix broken triage link) - #5424 (Incorrect suspicious_op_assign_impl) - #5425 (Ehance opt_as_ref_deref lint.) Failed merges: - #5411 (Downgrade implicit_hasher to pedantic) - #5428 (Move cognitive_complexity to nursery) r? @ghost changelog: rollup

bors · 2020-04-08T13:52:55Z

☔ The latest upstream changes (presumably #5429) made this pull request unmergeable. Please resolve the merge conflicts.

@ghost

Rollup of 11 pull requests Successful merges: - #5406 (Fix update_lints) - #5409 (Downgrade let_unit_value to pedantic) - #5410 (Downgrade trivially_copy_pass_by_ref to pedantic) - #5412 (Downgrade inefficient_to_string to pedantic) - #5415 (Add new lint for `Result<T, E>.map_or(None, Some(T))`) - #5417 (Update doc links and mentioned names in docs) - #5419 (Downgrade unreadable_literal to pedantic) - #5420 (Downgrade new_ret_no_self to pedantic) - #5422 (CONTRIBUTING.md: fix broken triage link) - #5424 (Incorrect suspicious_op_assign_impl) - #5425 (Ehance opt_as_ref_deref lint.) Failed merges: - #5345 (Add lint for float in array comparison) - #5411 (Downgrade implicit_hasher to pedantic) - #5428 (Move cognitive_complexity to nursery) r? @ghost changelog: rollup

flip1995 · 2020-04-08T14:58:58Z

@Toxyxer a rebase is required after the rollup #5438

bors · 2020-04-08T15:34:12Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout add-lint-for-float-in-array-comparison (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self add-lint-for-float-in-array-comparison --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging tests/ui/float_cmp_const.stderr
CONFLICT (content): Merge conflict in tests/ui/float_cmp_const.stderr
Auto-merging tests/ui/float_cmp_const.rs
Auto-merging tests/ui/float_cmp.stderr
CONFLICT (content): Merge conflict in tests/ui/float_cmp.stderr
Auto-merging tests/ui/float_cmp.rs
Auto-merging clippy_lints/src/misc.rs
CONFLICT (content): Merge conflict in clippy_lints/src/misc.rs
Auto-merging clippy_lints/src/consts.rs
Automatic merge failed; fix conflicts and then commit the result.

Finishes #4277

phansch · 2020-04-10T21:42:14Z

@bors retry

phansch · 2020-04-11T12:50:07Z

Ah.. that should have been
@bors r=flip1995

bors · 2020-04-11T12:50:08Z

📌 Commit 4449cc7 has been approved by flip1995

bors · 2020-04-11T12:50:15Z

⌛ Testing commit 4449cc7 with merge 2e6ff6e...

… r=flip1995 Add lint for float in array comparison Fixes #4277 changelog: - Added new handler for expression of index kind (e.g. `arr[i]`). It returns a constant when both array and index are constant, or when the array is constant and all values are equal. - Trigger float_cmp and float_cmp_const lint when comparing arrays. Allow for comparison when one of the arrays contains only zeros or infinities. - Added appropriate tests for such cases.

bors · 2020-04-11T13:06:43Z

💔 Test failed - checks-action_remark_test

marcin-serwin · 2020-04-15T05:42:27Z

Hey @flip1995,
Could you help me with the homu test fail? There is no information on why these checks failed.

phansch · 2020-04-15T05:49:13Z

This was probably just a random failure, let's try again

@bors retry

bors · 2020-04-15T05:57:36Z

⌛ Testing commit 4449cc7 with merge 756bb28...

… r=flip1995 Add lint for float in array comparison Fixes #4277 changelog: - Added new handler for expression of index kind (e.g. `arr[i]`). It returns a constant when both array and index are constant, or when the array is constant and all values are equal. - Trigger float_cmp and float_cmp_const lint when comparing arrays. Allow for comparison when one of the arrays contains only zeros or infinities. - Added appropriate tests for such cases.

phansch · 2020-04-15T06:39:09Z

Hmm, bors should have merged this by now.. Let's give this another try 🤷

@bors retry

bors · 2020-04-15T06:39:16Z

⌛ Testing commit 4449cc7 with merge a96f874...

bors · 2020-04-15T06:52:05Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a96f874 to master...

flip1995 requested a review from yaahc March 30, 2020 17:39

yaahc approved these changes Mar 30, 2020

View reviewed changes

yaahc requested a review from Manishearth March 30, 2020 18:48

flip1995 requested changes Mar 30, 2020

View reviewed changes

tests/ui/float_cmp.stderr Outdated Show resolved Hide resolved

tests/ui/float_cmp.stderr Outdated Show resolved Hide resolved

flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Mar 31, 2020

flip1995 requested changes Apr 6, 2020

View reviewed changes

tests/ui/float_cmp.stderr Outdated Show resolved Hide resolved

clippy_lints/src/misc.rs Outdated Show resolved Hide resolved

flip1995 approved these changes Apr 6, 2020

View reviewed changes

flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 6, 2020

flip1995 mentioned this pull request Apr 6, 2020

Use assoc int and float consts instead of module level ones #5429

Merged

flip1995 mentioned this pull request Apr 7, 2020

Rollup of 12 pull requests #5432

Closed

flip1995 mentioned this pull request Apr 8, 2020

Rollup of 11 pull requests #5438

Merged

phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-bors Status: The marked PR was approved and is only waiting bors labels Apr 9, 2020

briankabiro and others added 15 commits April 9, 2020 08:05

Add lint when comparing floats in an array

d440935

Finishes #4277

Add tests for float in array comparison

0d00eaf

Update field names in is_float

03f584c

Update stderr of float_cmp test

b4ff774

Add handling of float arrays to miri_to_const

2153abb

Handle evaluating constant index expression

6217671

Allow for const arrays of zeros

bcbb9d9

Don't show comparison suggestion for arrays

1bab67c

Handle constant arrays with single value

d3167c6

Add float cmp tests for arrays

3c738b2

Add float cmp const tests for arrays

c7b5e30

Make epsilon note spanless when comparing arrays

84ae3d8

Indicate when arrays are compared in error message

f637c45

Split check_fn function

4e01ca3

Make the epsilon note spanless

4449cc7

bors merged commit a96f874 into rust-lang:master Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint for float in array comparison #5345

Add lint for float in array comparison #5345

marcin-serwin commented Mar 20, 2020

flip1995 commented Mar 30, 2020

yaahc left a comment

marcin-serwin commented Apr 6, 2020 •

edited

Loading

flip1995 commented Apr 6, 2020

marcin-serwin commented Apr 6, 2020

flip1995 commented Apr 6, 2020

flip1995 commented Apr 6, 2020 •

edited

Loading

marcin-serwin commented Apr 6, 2020

flip1995 commented Apr 7, 2020

bors commented Apr 7, 2020

bors commented Apr 7, 2020

bors commented Apr 8, 2020

flip1995 commented Apr 8, 2020

bors commented Apr 8, 2020

phansch commented Apr 10, 2020

phansch commented Apr 11, 2020

bors commented Apr 11, 2020

bors commented Apr 11, 2020

bors commented Apr 11, 2020

marcin-serwin commented Apr 15, 2020

phansch commented Apr 15, 2020

bors commented Apr 15, 2020

phansch commented Apr 15, 2020

bors commented Apr 15, 2020

bors commented Apr 15, 2020

Add lint for float in array comparison #5345

Add lint for float in array comparison #5345

Conversation

marcin-serwin commented Mar 20, 2020

flip1995 commented Mar 30, 2020

yaahc left a comment

Choose a reason for hiding this comment

marcin-serwin commented Apr 6, 2020 • edited Loading

flip1995 commented Apr 6, 2020

marcin-serwin commented Apr 6, 2020

flip1995 commented Apr 6, 2020

flip1995 commented Apr 6, 2020 • edited Loading

marcin-serwin commented Apr 6, 2020

flip1995 commented Apr 7, 2020

bors commented Apr 7, 2020

bors commented Apr 7, 2020

bors commented Apr 8, 2020

flip1995 commented Apr 8, 2020

bors commented Apr 8, 2020

phansch commented Apr 10, 2020

phansch commented Apr 11, 2020

bors commented Apr 11, 2020

bors commented Apr 11, 2020

bors commented Apr 11, 2020

marcin-serwin commented Apr 15, 2020

phansch commented Apr 15, 2020

bors commented Apr 15, 2020

phansch commented Apr 15, 2020

bors commented Apr 15, 2020

bors commented Apr 15, 2020

marcin-serwin commented Apr 6, 2020 •

edited

Loading

flip1995 commented Apr 6, 2020 •

edited

Loading