-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More lint pass merges #8957
More lint pass merges #8957
Conversation
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #8960) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #8964) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #9103) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #9148) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM. I left one comment. But if you think that my suggestions makes the code style worse, you can just discard it.
Feel free to r=me after rebase and potentially addressing my comment.
Sorry for taking so long!
f7f4bd5
to
d8808db
Compare
@bors r+ Thanks! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Remove `dead_code` paths The following paths are `dead_code` and can be removed: ### `clippy_utils::paths::VEC_RESIZE` * Introduced when `vec_resize_to_zero` lint added in PR #5637 * No longer used after commit 8acc4d2 ### `clippy_utils::paths::SLICE_GET` * Introduced when `get_first` lint added in PR #8882 * No longer used after commit a8d80d5 ### `clippy_utils::paths::STR_BYTES` * Introduced when `bytes_count_to_len` lint added in PR #8711 * No longer used after commit ba6a459 When the lints were moved into the `Methods` lint pass, they switched from using paths to diagnostic items. However, the paths were never removed. This occurred in PR #8957. This relates to issue #5393 changelog: none
changelog: None