Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lint pass merges #8957

Merged
merged 20 commits into from
Aug 19, 2022
Merged

More lint pass merges #8957

merged 20 commits into from
Aug 19, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jun 6, 2022

changelog: None

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 6, 2022
@Jarcho Jarcho force-pushed the more_pass_merges branch from f132cca to 0b0eaf0 Compare June 6, 2022 16:38
@bors
Copy link
Contributor

bors commented Jun 8, 2022

☔ The latest upstream changes (presumably #8960) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the more_pass_merges branch from 0b0eaf0 to 6e779a8 Compare June 11, 2022 23:47
@bors
Copy link
Contributor

bors commented Jun 15, 2022

☔ The latest upstream changes (presumably #8964) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the more_pass_merges branch from 6e779a8 to b696631 Compare July 9, 2022 21:28
@bors
Copy link
Contributor

bors commented Jul 15, 2022

☔ The latest upstream changes (presumably #9103) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the more_pass_merges branch from b696631 to f7f4bd5 Compare July 17, 2022 23:41
@bors
Copy link
Contributor

bors commented Jul 18, 2022

☔ The latest upstream changes (presumably #9148) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM. I left one comment. But if you think that my suggestions makes the code style worse, you can just discard it.

Feel free to r=me after rebase and potentially addressing my comment.

Sorry for taking so long!

clippy_lints/src/methods/range_zip_with_len.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 19, 2022
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 19, 2022

📌 Commit d8808db has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 19, 2022

⌛ Testing commit d8808db with merge 477c16d...

@bors
Copy link
Contributor

bors commented Aug 19, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 477c16d to master...

@bors bors merged commit 477c16d into rust-lang:master Aug 19, 2022
@CBSpeir CBSpeir mentioned this pull request May 1, 2024
bors added a commit that referenced this pull request May 2, 2024
Remove `dead_code` paths

The following paths are `dead_code` and can be removed:

### `clippy_utils::paths::VEC_RESIZE`
* Introduced when `vec_resize_to_zero` lint added in PR #5637
* No longer used after commit 8acc4d2
### `clippy_utils::paths::SLICE_GET`
* Introduced when `get_first` lint added in PR #8882
* No longer used after commit a8d80d5
### `clippy_utils::paths::STR_BYTES`
* Introduced when `bytes_count_to_len` lint added in PR #8711
* No longer used after commit ba6a459

When the lints were moved into the `Methods` lint pass, they switched from using paths to diagnostic items.  However, the paths were never removed.  This occurred in PR #8957.

This relates to issue #5393

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants