Ensure Monaco measures fonts after the font is loaded #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon as Monaco is instantiated, it measures various aspects of the chosen font. Since the playground fetches fonts, the fonts may not yet be available to be measured. After a bit, the fonts are loaded but Monaco's cached results are now out of date. We now trigger a remeasurement of the fonts after our fonts are available. For some reason, this has only been reported by people using Microsoft Edge, but theoretically it should occur in any browser. Perhaps there's something unique about Edge's text rendering? It also only occurs at certain original zoom levels — on my computer, it needed 125% zoom. Note that each zoom level has different font metrics, so changing the zoom once the font is loaded will work although the original incorrect metrics will still be cached. Fixes #1103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as Monaco is instantiated, it measures various aspects of the
chosen font. Since the playground fetches fonts, the fonts may not yet
be available to be measured. After a bit, the fonts are loaded but
Monaco's cached results are now out of date.
We now trigger a remeasurement of the fonts after our fonts are
available.
For some reason, this has only been reported by people using Microsoft
Edge, but theoretically it should occur in any browser. Perhaps
there's something unique about Edge's text rendering? It also only
occurs at certain original zoom levels — on my computer, it needed
125% zoom. Note that each zoom level has different font metrics, so
changing the zoom once the font is loaded will work although the
original incorrect metrics will still be cached.
Fixes #1103