Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a favicon #321

Closed
wants to merge 1 commit into from
Closed

Add a favicon #321

wants to merge 1 commit into from

Conversation

KamilaBorowska
Copy link
Contributor

Fixes #23.

@KamilaBorowska KamilaBorowska changed the title Add favicon Add a favicon May 3, 2018
@shepmaster
Copy link
Member

Thanks! A few questions...

  1. Where is this icon from / what is the licensing?
  2. Would you add the modern <head> tags as listed in https://github.com/joshbuchea/HEAD#icons

@KamilaBorowska
Copy link
Contributor Author

The icon comes from https://www.rust-lang.org/favicon.ico, the licensing is CC-BY according to https://www.rust-lang.org/en-US/legal.html (although worth noting it's also a trademark).

Hm, yeah, that seems like a possible legal issue due to also being hosted on play.integer32.com. If it was just play.rust-lang.org, it probably would be fine (it's pretty much official here, and old playpen had an exactly same favicon), but eh...

@shepmaster
Copy link
Member

I'll try to ask around about the licensing of that.

@AndreaCatania
Copy link

A favicon would be a good improvement, actually the bookmarked link look really bad in my bookmark bar, I hope that this can be merged any time soon.

I think that a gear with a play icon at center will work and you can avoid any licensing problem.

@lpmi-13
Copy link
Contributor

lpmi-13 commented Jul 9, 2020

has there been any movement on this? Had a look around at the "official" rust logos, and it might be easiest to just mock up a gear with something else inside of it...should be simple enough to find a suitable image.

For example, the three below are all free for commercial use, with no attribution required (I assume that covers "use for a free open source project"):
https://pixabay.com/vectors/gear-mechanics-settings-icon-1119298/
https://pixabay.com/vectors/gear-settings-options-icon-1077550/
https://pixabay.com/vectors/gear-wheel-gears-toothed-wheel-304395/

Would it be worth just turning one of these into a favicon sized image to get rid of that pesky console error?

@shepmaster
Copy link
Member

has there been any movement on this?

Nope.

There is a channel on Discord for public-facing Rust web properties, so that's one place we could ask for broader feedback.

My opinion is that it should be distinct but related to the favicon on http://rust-lang.org.

@imjasonmiller imjasonmiller mentioned this pull request Apr 14, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a favicon
4 participants