Skip to content

Commit

Permalink
Auto merge of #110410 - saethlin:hash-u128-as-u64s, r=oli-obk
Browse files Browse the repository at this point in the history
Implement StableHasher::write_u128 via write_u64

In #110367 (comment) the cachegrind diffs indicate that nearly all the regression is from this:
```
22,892,558  ???:<rustc_data_structures::sip128::SipHasher128>::slice_write_process_buffer
-9,502,262  ???:<rustc_data_structures::sip128::SipHasher128>::short_write_process_buffer::<8>
```
Which happens because the diff for that perf run swaps a `Hash::hash` of a `u64` to a `u128`. But `slice_write_process_buffer` is a `#[cold]` function, and is for handling hashes of arbitrary-length byte arrays.

Using the much more optimizer-friendly `u64` path twice to hash a `u128` provides a nice perf boost in some benchmarks.
  • Loading branch information
bors committed Apr 18, 2023
2 parents e279f90 + ad8d304 commit 3860251
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion compiler/rustc_data_structures/src/stable_hasher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ impl Hasher for StableHasher {

#[inline]
fn write_u128(&mut self, i: u128) {
self.state.write(&i.to_le_bytes());
self.write_u64(i as u64);
self.write_u64((i >> 64) as u64);
}

#[inline]
Expand Down

0 comments on commit 3860251

Please sign in to comment.