Skip to content

Commit

Permalink
Rollup merge of #111069 - ozkanonur:remove-pointless-fixme, r=albertl…
Browse files Browse the repository at this point in the history
…arsan68

remove pointless `FIXME` in `bootstrap::download`

The suggestion given by `FIXME` to use `CompilerMetadata` for `download_toolchain` in `bootstrap::download` can result in more confusion. This is because `stamp_key` is not always a date; it can also be a commit hash. Additionally, unlike in `download_beta_toolchain`, in the `download_ci_rustc` function, `version` and `commit` values are calculated separately.
  • Loading branch information
matthiaskrgr authored May 1, 2023
2 parents ffd8460 + bc68de9 commit 5945ab8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/bootstrap/download.rs
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,6 @@ impl Config {

fn download_toolchain(
&self,
// FIXME(ozkanonur) use CompilerMetadata instead of `version: &str`
version: &str,
sysroot: &str,
stamp_key: &str,
Expand Down

0 comments on commit 5945ab8

Please sign in to comment.