Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_deferred is incorrect for SingleThreaded tasks #10345

Closed
brson opened this issue Nov 8, 2013 · 2 comments
Closed

send_deferred is incorrect for SingleThreaded tasks #10345

brson opened this issue Nov 8, 2013 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@brson
Copy link
Contributor

brson commented Nov 8, 2013

When send_deferred sees a task to wake up it calls enqueue_blocked_task to reschedule the work, but enqueue_blocked_task assumes that some other scheduler will come along to steal the work. For tasks spawned with SingleThreaded scheduling though, the scheduler doesn't participate in work stealing, so if the task then goes on to block, the other task will never wake up.
@alexcrichton
Copy link
Member

This will be closed by #10965

@alexcrichton
Copy link
Member

send_deferred is now (mostly) gone

Jarcho pushed a commit to Jarcho/rust that referenced this issue Feb 26, 2023
@bors
Auto merge of rust-lang#10345 - J-ZhengLi:issue_10049, r=xFrednet
d3d235d 
fix [`needless_return`] incorrect suggestion when returning if sequence

fixes: rust-lang#10049

---

changelog: [`needless_return`]: fix incorrect suggestion  on if sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @brson