Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rust.lto=off to bootstrap for faster dev builds #107202

Closed
the8472 opened this issue Jan 22, 2023 · 3 comments · Fixed by #107241
Closed

Add support for rust.lto=off to bootstrap for faster dev builds #107202

the8472 opened this issue Jan 22, 2023 · 3 comments · Fixed by #107241
Assignees
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@the8472
Copy link
Member

the8472 commented Jan 22, 2023

Currently bootstrap supports LTO flavors thin-local (default), thin and fat. Adding the option to completely disable it can speed up develop cycles, especially with incremental compilation. See this Zulip thread for benchmarks.

/// LTO mode used for compiling rustc itself.
#[derive(Default, Clone)]
pub enum RustcLto {
#[default]
ThinLocal,
Thin,
Fat,
}

When LTO is disabled the standard library still has to be built with -Cembed-bitcode=on so that it can be used by other crates which enable LTO.

Disabling should become the default for the library and compiler profile templates.

@the8472 the8472 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 22, 2023
@the8472 the8472 changed the title Add support for rust.lto=off to bootstrap. Add support for rust.lto=off to bootstrap for faster dev builds Jan 22, 2023
@albertlarsan68
Copy link
Member

@rustbot claim to not loose it to time, but feel free to claim it if you want, I might not start work on this until February.

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2023

Error: Parsing assign command in comment failed: ...' claim' | error: expected end of command at >| ' to not lo'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@albertlarsan68
Copy link
Member

@rustbot claim
Shouldn't this bot be able to detect end of command and silently ignore the rest of the line ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants