Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust 1.67.0 fails to recognize thin archive #107334

Closed
jpalus opened this issue Jan 26, 2023 · 8 comments
Closed

rust 1.67.0 fails to recognize thin archive #107334

jpalus opened this issue Jan 26, 2023 · 8 comments
Assignees
@pnkfelix
Labels
C-bug Category: This is a bug. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jpalus
Copy link

jpalus commented Jan 26, 2023 •
edited
Loading

Code

Build of Mesa 22.3.4 (enabled rusticl) on Linux/aarch64 with rust 1.67.0 fails with:

error: failed to add native library src/gallium/auxiliary/libgallium.a: Unsupported archive identifier

where:

$ file build/src/gallium/auxiliary/libgallium.a
build/src/gallium/auxiliary/libgallium.a: thin archive with 1344 symbol entries

Version it worked on

Builds fine with rust 1.66.0.

Version with regression

Stable release of rust 1.67.0
@jpalus jpalus added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Jan 26, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 26, 2023
@lqd lqd mentioned this issue Jan 26, 2023
Closed
@bjorn3 bjorn3 mentioned this issue Jan 27, 2023
Merged
@cuviper cuviper added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-untriaged Untriaged performance or correctness regression. labels Jan 27, 2023
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 28, 2023
@bors
Auto merge of rust-lang#107360 - bjorn3:fix_thin_archive_reading, r=w…
2527416 
…esleywiser

Fix thin archive reading

This includes a revert of rust-lang#105221 to restore fat archive reading with LlvmArchiveBuilder.

Should fix rust-lang#107162, rust-lang#107334 and google/shaderc-rs#133
@karolherbst
Copy link

thanks for bringing this to my attention as well. I can confirm that I also hit the same issue.

@apiraino
Copy link
Contributor

@jpalus when you have a chance can you check if #107360 (now available in a recent nightly) fixes also this issue? Thanks

@jpalus
Copy link
Author

jpalus commented Jan 31, 2023

@apiraino I've already commented on #107360 that it does.

@apiraino
Copy link
Contributor

sorry, I missed that comment. thanks

@trofi trofi mentioned this issue Jan 31, 2023
Merged
13 tasks
@pnkfelix
Copy link
Member

pnkfelix commented Feb 2, 2023

@rustbot label: E-needs-test

@rustbot rustbot added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Feb 2, 2023
@pnkfelix pnkfelix self-assigned this Feb 2, 2023
@pnkfelix pnkfelix mentioned this issue Feb 2, 2023
Merged
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 3, 2023
@Firstyear
Copy link
Contributor

Will this issue trigger a release of 1.67.1 or will we need to apply the patches for this ourselves in distros?

bors added a commit to rust-lang-ci/rust that referenced this issue Feb 8, 2023
@bors
Auto merge of rust-lang#107609 - pnkfelix:backport-reverts-to-fix-thi…
5a6594b 
…n-archive-reading-for-1-68-beta, r=cuviper

Backport reverts to fix thin archive reading for 1 68 beta

This is a backport of PR rust-lang#107360 aimed at beta.

cc rust-lang#107162, rust-lang#107334 and google/shaderc-rs#133
@apiraino
Copy link
Contributor

apiraino commented Feb 9, 2023

@Firstyear yes, a 1.67.1 is planned (see draft of the blog post)

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 23, 2023
@cuviper
Copy link
Member

cuviper commented Mar 11, 2023

We did release this in 1.67.1, and 1.68.0 also got the patch added while it was in beta.

@cuviper cuviper closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
C-bug Category: This is a bug. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@cuviper @karolherbst @pnkfelix @Firstyear @jpalus @apiraino @rustbot