Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc search should allow as a separator in addition to :: #108447

Closed
thomcc opened this issue Feb 25, 2023 · 1 comment · Fixed by #108537
Closed

Rustdoc search should allow as a separator in addition to :: #108447

thomcc opened this issue Feb 25, 2023 · 1 comment · Fixed by #108537
Assignees
@GuillaumeGomez
Labels
A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@thomcc
Copy link
Member

thomcc commented Feb 25, 2023

If I search vec push in the stdlib docs, it brings me to this page which currently has no results. This is unfortunate, and I hit it probably at least once a day, and may not be alone.

Searching instead for vec::push works, but it would be nice if it were not necessary, and the delimiter could be as well.
@thomcc thomcc added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-search Area: Rustdoc's search feature labels Feb 25, 2023
@GuillaumeGomez
Copy link
Member

Sounds acceptable. It'll need to go through FCP I think but otherwise I think it makes sense.

@GuillaumeGomez GuillaumeGomez self-assigned this Feb 25, 2023
@GuillaumeGomez GuillaumeGomez mentioned this issue Feb 27, 2023
Merged
@bors bors closed this as completed in bf0e22b Jul 2, 2023
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jul 3, 2023
@bors
Auto merge of #108537 - GuillaumeGomez:rustdoc-search-whitespace-as-s…
000db75 
…eparator, r=notriddle

rustdoc: Allow whitespace as path separator like double colon

Fixes rust-lang/rust#108447.

I think it makes sense since it allows more common cases, however it also makes the syntax heavier. Not sure what the rest of the team thinks about it. In any case we'll need to go through FCP.

Full explanation for the changes is available [here](rust-lang/rust#108537 (comment)).

r? `@notriddle`
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
@bors
Auto merge of #108537 - GuillaumeGomez:rustdoc-search-whitespace-as-s…
01a6eab 
…eparator, r=notriddle

rustdoc: Allow whitespace as path separator like double colon

Fixes rust-lang/rust#108447.

I think it makes sense since it allows more common cases, however it also makes the syntax heavier. Not sure what the rest of the team thinks about it. In any case we'll need to go through FCP.

Full explanation for the changes is available [here](rust-lang/rust#108537 (comment)).

r? `@notriddle`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #108537 - GuillaumeGomez:rustdoc-search-whitespace-as-s…
2b6a132 
…eparator, r=notriddle

rustdoc: Allow whitespace as path separator like double colon

Fixes rust-lang/rust#108447.

I think it makes sense since it allows more common cases, however it also makes the syntax heavier. Not sure what the rest of the team thinks about it. In any case we'll need to go through FCP.

Full explanation for the changes is available [here](rust-lang/rust#108537 (comment)).

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Allow whitespace as path separator like double colon GuillaumeGomez/rust
2 participants
@thomcc @GuillaumeGomez