Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x clean --stage 1 silently does the wrong thing #109313

Closed
jyn514 opened this issue Mar 18, 2023 · 0 comments · Fixed by #114126
Closed

x clean --stage 1 silently does the wrong thing #109313

jyn514 opened this issue Mar 18, 2023 · 0 comments · Fixed by #114126
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 18, 2023

I tried this code:

x clean --stage 1

I expected to see this happen: bootstrap only deletes stage 1 artifacts:

; ls build/x86_64-unknown-linux-gnu/stage1* -d
build/x86_64-unknown-linux-gnu/stage1        build/x86_64-unknown-linux-gnu/stage1-tools
build/x86_64-unknown-linux-gnu/stage1-rustc  build/x86_64-unknown-linux-gnu/stage1-tools-bin
build/x86_64-unknown-linux-gnu/stage1-std

Instead, this happened: bootstrap completely ignored the --stage flag and deleted everything in the build directory except for cache.

Meta

HEAD is branched from 13afbda
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Mar 18, 2023
@onur-ozkan onur-ozkan self-assigned this Jul 27, 2023
@onur-ozkan onur-ozkan mentioned this issue Jul 27, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jul 30, 2023
@Dylan-DPC
Rollup merge of rust-lang#114126 - ozkanonur:stage-support-for-clean,…
71c17d7 
… r=albertlarsan68

clean stage-specific artifacts using `x clean --stage`

fixes rust-lang#109313
@bors bors closed this as completed in d9feb02 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean stage-specific artifacts using x clean --stage onur-ozkan/rust
2 participants
@jyn514 @onur-ozkan