x.ps1 does not fail the build #111136
Labels
C-bug
Category: This is a bug.
P-high
High priority
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
The
x.ps1
shell script does not return with an exit code if the build fails. Theprocess.ExitCode
object doesn't appear to be an integer.cc @rust-lang/bootstrap This may be an important issue since something could potentially fail in CI without failing the build.
Noticed in CI when something funky happened. Fortunately the metrics don't get created when a test fails (I think), but there may be other situations where it isn't working correctly.
This looks like it was added in #99992.
The text was updated successfully, but these errors were encountered: