-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error code from x.ps1 #111141
Return error code from x.ps1 #111141
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
I also added at check that we can get the exit code. So if it does return null again, it'll be a hard error. |
@bors r+ rollup p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f557a4f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 654.067s -> 655.771s (0.26%) |
Fixes #111136
This works around a bug where
ExitCode
does not return the exit code. See: https://stackoverflow.com/a/23797762