Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: --fail-fast doesn't work anymore #113208

Closed
jyn514 opened this issue Jun 30, 2023 · 2 comments · Fixed by #113214
Closed

bootstrap: --fail-fast doesn't work anymore #113208

jyn514 opened this issue Jun 30, 2023 · 2 comments · Fixed by #113214
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 30, 2023

fail_fast is broken because anything calling try_run will panic immediately instead of waiting for all other steps to finish running.

@GuillaumeGomez do you have time to follow up here?

Originally posted by @jyn514 in #112962 (comment)
@jyn514 jyn514 added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 30, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jun 30, 2023
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jun 30, 2023
@jyn514 jyn514 changed the title --fail-fast doesn't work anymore bootstrap: --fail-fast doesn't work anymore Jun 30, 2023
@GuillaumeGomez
Copy link
Member

Sure.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jun 30, 2023
Merged
@hameerabbasi
Copy link
Contributor

Removing I-prioritize since this is already being worked on/in review.

@rustbot label -I-prioritize

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 1, 2023
@bors bors closed this as completed in 1e6db34 Jul 12, 2023
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jul 13, 2023
@bors
Auto merge of #113214 - GuillaumeGomez:try-run-fix, r=ozkanonur,jyn514
3828971 
Don't fail early if `try_run` returns an error

Fixes rust-lang/rust#113208.

Follow-up of #112962.

r? `@jyn514`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't fail early if try_run returns an error GuillaumeGomez/rust
4 participants
@hameerabbasi @GuillaumeGomez @jyn514 @rustbot