Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid checksum in bootstrap #115275

Closed
Alexendoo opened this issue Aug 27, 2023 · 0 comments · Fixed by #115323
Closed

Invalid checksum in bootstrap #115275

Alexendoo opened this issue Aug 27, 2023 · 0 comments · Fixed by #115323
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Alexendoo
Copy link
Member

on d1fb175 I ran ./x clean after doing a git pull (unsure from what commit) and got:

downloading https://static.rust-lang.org/dist/2023-08-22/rustc-nightly-aarch64-unknown-linux-gnu.tar.xz
#####                                                                                                                                                                                                    2.6%
curl: (28) Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds
Warning: Problem : timeout. Will retry in 1 seconds. 3 retries left.
######################################################                                                                                                                                                  27.5%
curl: (28) Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds
Warning: Problem : timeout. Will retry in 2 seconds. 2 retries left.
###################################################################################################################################################################################################### 100.0%
invalid checksum: 
found:    bd65ba88eff2a212f87030efe2098bdd2ffdcc770fe3b52e0731c830739dd48a
expected: 95b36f95b1e697922b6dceeaceb74da030d436340cb4ba764101c218c3bcb786
thread 'main' panicked at download.rs:606:17:
failed to verify /home/gh-Alexendoo/rust/build/cache/2023-08-22/rustc-nightly-aarch64-unknown-linux-gnu.tar.xz
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:04:01

./x after moving the build dir to build2 worked fine

It may be an issue with the download retry logic, it seems to be larger than expected

$ curl -L https://static.rust-lang.org/dist/2023-08-22/rustc-nightly-aarch64-unknown-linux-gnu.tar.xz | wc -c
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 76.2M  100 76.2M    0     0  11.5M      0  0:00:06  0:00:06 --:--:-- 6205k
79976028
$ wc -c build2/cache/2023-08-22/rustc-nightly-aarch64-unknown-linux-gnu.tar.xz
104093276 build2/cache/2023-08-22/rustc-nightly-aarch64-unknown-linux-gnu.tar.xz
@Alexendoo Alexendoo added the C-bug Category: This is a bug. label Aug 27, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 27, 2023
@lqd lqd mentioned this issue Aug 27, 2023
Merged
@onur-ozkan onur-ozkan added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 27, 2023
@onur-ozkan onur-ozkan self-assigned this Aug 27, 2023
@onur-ozkan onur-ozkan mentioned this issue Aug 28, 2023
Merged
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 30, 2023
@matthiaskrgr
Rollup merge of rust-lang#115323 - onur-ozkan:curl-download-checksum-…
fee68a0 
…fix, r=Mark-Simulacrum

avoid stdout redirection on `curl` executions

Avoid redirecting the curl output directly to the stdout. This alteration affects the integrity of the file during the retry process, as it also redirects the logs from the retries. Consequently, this leads to the bootstrap process failing because of an invalid checksum.

For more information, see the [zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/checksum.20errors)

Fixes rust-lang#115275
@bors bors closed this as completed in 008c21c Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid stdout redirection on curl executions onur-ozkan/rust
3 participants
@Alexendoo @onur-ozkan @rustbot