Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.72.1 is not released on GitHub #115976

Closed
sksat opened this issue Sep 19, 2023 · 6 comments
Closed

1.72.1 is not released on GitHub #115976

sksat opened this issue Sep 19, 2023 · 6 comments
Labels
T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@sksat
Copy link

sksat commented Sep 19, 2023

The 1.72.1 release was announced: https://blog.rust-lang.org/2023/09/19/Rust-1.72.1.html
Actually, this tag exists: https://github.com/rust-lang/rust/releases/tag/1.72.1

However, this version does not seem to exist in GitHub Releases: https://github.com/rust-lang/rust/releases
It seems that this operation is usually done by a bot, so is there some problem with the automated release procedure?
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 19, 2023
@Mark-Simulacrum
Copy link
Member

I suspect we need to copy the release notes to master.

@sksat sksat mentioned this issue Sep 19, 2023
Merged
@sksat
Copy link
Author

sksat commented Sep 19, 2023

@Mark-Simulacrum I tried to respond with #115978, is this what you meant?

@saethlin saethlin added T-release Relevant to the release subteam, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 19, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Sep 20, 2023
@matthiaskrgr
Rollup merge of rust-lang#115978 - sksat:copy-1.72.1-release-note-to-…
24fc098 
…master, r=Mark-Simulacrum

Copy 1.72.1 release notes to master

- rust-lang#115976
- this cherry-pick 1.72.1 release note from rust-lang#115787(0414f85)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 20, 2023
@rust-timer
Unrolled build for rust-lang#115978
e5b7ca2 
Rollup merge of rust-lang#115978 - sksat:copy-1.72.1-release-note-to-master, r=Mark-Simulacrum

Copy 1.72.1 release notes to master

- rust-lang#115976
- this cherry-pick 1.72.1 release note from rust-lang#115787(0414f85)
@fmease
Copy link
Member

fmease commented Sep 20, 2023

https://github.com/rust-lang/rust/releases/tag/1.72.1

@fmease fmease closed this as completed Sep 20, 2023
@frederikrothenberger
Copy link

@fmease: Why is the release not marked as latest? What is the authoritative source of the latest version?

@fmease
Copy link
Member

fmease commented Sep 22, 2023

Good catch! At the moment, 1.71.1 is flagged as latest presumably since the release notes for 1.71.1 (#115997) were merged several hours after the ones for 1.72.1 (#115978).

I'm not a T-release member and I'm not super familiar with GitHub releases.
@Mark-Simulacrum, is there a simple way to mark 1.72.1 as latest?

Merged
@Mark-Simulacrum
Copy link
Member

Should be fixed.

@sksat sksat mentioned this issue Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Mark-Simulacrum @saethlin @fmease @sksat @rustbot @frederikrothenberger