You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, that's not all tier 1 targets, so e.g. x86_64-apple-darwin is not covered, and today's nightly contains a Miri where some APIs are broken on x86_64-apple-darwin.
It'd be great if we could run (some) Miri tests on all tier 1 targets. Note that Miri tests can be run on any host so this does not require running checktools.sh on more hosts. However we'd probably not want to test all targets on all hosts, so we need some way in checktools.sh to determine which host we are on, and spread the test jobs across the hosts. Also, depending on how tight our time budget is here, we might want to not run all tests -- just running the "pass" tests should generally be sufficient and can save a bunch of time.
Cc @rust-lang/infra -- in particular, (a) how can I check for the host in checktools.sh, and (b) how tight is our time budget for the "tools" builders?
The text was updated successfully, but these errors were encountered:
RalfJung
added
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
A-miri
Area: The miri tool
A-CI
Area: Our Github Actions CI
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Oct 25, 2023
update which targets we test Miri on
I hope this doesn't cost too much time; running only the "pass" tests should be reasonably fast (1-2 minutes on my system).
Fixesrust-lang#117167
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Oct 29, 2023
update which targets we test Miri on
I hope this doesn't cost too much time; running only the "pass" tests should be reasonably fast (1-2 minutes on my system).
Fixesrust-lang#117167
update which targets we test Miri on
I hope this doesn't cost too much time; running only the "pass" tests should be reasonably fast (1-2 minutes on my system).
Fixesrust-lang/rust#117167
We currently run Miri on tests a few select targets:
rust/src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh
Lines 27 to 32 in c905fd2
However, that's not all tier 1 targets, so e.g. x86_64-apple-darwin is not covered, and today's nightly contains a Miri where some APIs are broken on x86_64-apple-darwin.
It'd be great if we could run (some) Miri tests on all tier 1 targets. Note that Miri tests can be run on any host so this does not require running checktools.sh on more hosts. However we'd probably not want to test all targets on all hosts, so we need some way in checktools.sh to determine which host we are on, and spread the test jobs across the hosts. Also, depending on how tight our time budget is here, we might want to not run all tests -- just running the "pass" tests should generally be sufficient and can save a bunch of time.
Cc @rust-lang/infra -- in particular, (a) how can I check for the host in checktools.sh, and (b) how tight is our time budget for the "tools" builders?
The text was updated successfully, but these errors were encountered: