Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for anonymous pipe API #127154

Open
3 of 4 tasks
NobodyXu opened this issue Jun 30, 2024 · 7 comments
Open
3 of 4 tasks

Tracking Issue for anonymous pipe API #127154

NobodyXu opened this issue Jun 30, 2024 · 7 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-anonymous_pipe `#![feature(anonymous_pipe)]` I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@NobodyXu
Copy link
Contributor

NobodyXu commented Jun 30, 2024

This is a tracking issue for the ACP rust-lang/libs-team#375 .
The feature gate for the issue is #![feature(anonymous_pipe)].

Steps

Implementation history

@NobodyXu NobodyXu added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jun 30, 2024
@Fulgen301
Copy link
Contributor

You might want to fix the typo in the title and feature name - it's an anonymous pipe, not an annoymous pipe.

@NobodyXu NobodyXu changed the title Tracking Issue for annoymous_pipe API Tracking Issue for anonymous pipe API Jun 30, 2024
@NobodyXu
Copy link
Contributor Author

Thanks!

I've fixed the typo in this issue and the linked PR.

jhpratt added a commit to jhpratt/rust that referenced this issue Jul 11, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 12, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
jhpratt added a commit to jhpratt/rust that referenced this issue Jul 13, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 14, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 15, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
tgross35 added a commit to tgross35/rust that referenced this issue Jul 16, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 18, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 18, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 20, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 20, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 21, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 22, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 23, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 24, 2024
Initial implementation of anonymous_pipe API

ACP completed in rust-lang/libs-team#375
Tracking issue: rust-lang#127154

try-job: x86_64-msvc
try-job: i686-mingw
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jul 28, 2024

I think we can now add specialisation to std::io::copy for std::pipe

jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 3, 2024
…viper

Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`

Enable `std::io::copy` specialisation on unix for the newly added anonymous pipe API, tracking issue rust-lang#127154
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 3, 2024
…viper

Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`

Enable `std::io::copy` specialisation on unix for the newly added anonymous pipe API, tracking issue rust-lang#127154
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 3, 2024
Rollup merge of rust-lang#128303 - NobodyXu:specialise-for-pipe, r=cuviper

Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`

Enable `std::io::copy` specialisation on unix for the newly added anonymous pipe API, tracking issue rust-lang#127154
@NobodyXu
Copy link
Contributor Author

I'm thinking about a new method for checked conversion from OwnedFd on unix.

I think it would be quite helpful for jobserver-rs

@RalfJung
Copy link
Member

Currently the documentation for this module is very bare-bones, quite far from the depth and quality we are used to in other parts of the standard library. There's not even a single example. This should be resolved before stabilization.

@jieyouxu jieyouxu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 9, 2024
@jieyouxu jieyouxu added the F-anonymous_pipe `#![feature(anonymous_pipe)]` label Dec 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 14, 2024
…documentation, r=tgross35

Add documentation for anonymous pipe module

Tracking issue: rust-lang#127154

`@NobodyXu` I've been using this feature lately and thought I might contribute with some documentation. I borrowed liberally from [os_pipe](https://docs.rs/os_pipe/latest/os_pipe/) so thanks to `@oconnor663.`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 15, 2024
Rollup merge of rust-lang#133986 - olishmollie:tracking-issue-127154-documentation, r=tgross35

Add documentation for anonymous pipe module

Tracking issue: rust-lang#127154

`@NobodyXu` I've been using this feature lately and thought I might contribute with some documentation. I borrowed liberally from [os_pipe](https://docs.rs/os_pipe/latest/os_pipe/) so thanks to `@oconnor663.`
@NobodyXu
Copy link
Contributor Author

@olishmollie has added e examples and improve documentation in #133986, does it mean it can be stabilised @RalfJung

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Dec 15, 2024
@RalfJung
Copy link
Member

That's up for the team to decide. I have nominated this for team discussion to get them to take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-anonymous_pipe `#![feature(anonymous_pipe)]` I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants