Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Cmin-function-alignment/-Calign-functions support in rustc #128830

Closed
ojeda opened this issue Aug 8, 2024 · 2 comments
Closed

-Cmin-function-alignment/-Calign-functions support in rustc #128830

ojeda opened this issue Aug 8, 2024 · 2 comments
Labels
A-rust-for-linux Relevant for the Rust-for-Linux project C-feature-request Category: A feature request, i.e: not implemented / a PR. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ojeda
Copy link
Contributor

ojeda commented Aug 8, 2024

i.e. the equivalents of -fmin-function-alignment (GCC, Clang does not support it) / -falign-functions (GCC, Clang).

For the Linux kernel, the behavior wanted is that of GCC's -fmin-function-alignment and Clang's -falign-functions, i.e. align all functions, including cold functions.

There is feature(fn_align), but we need to do it globally.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 8, 2024
@ojeda
Copy link
Contributor Author

ojeda commented Aug 8, 2024

@rustbot label I-rust-for-linux

@rustbot rustbot added the A-rust-for-linux Relevant for the Rust-for-Linux project label Aug 8, 2024
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 8, 2024
@workingjubilee
Copy link
Member

If a feature should be extended with a CLI flag, or at least have its interactions with such a flag considered before landing it, that should be brought up in that issue. Closing as duplicate for now.

@workingjubilee workingjubilee closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust-for-linux Relevant for the Rust-for-Linux project C-feature-request Category: A feature request, i.e: not implemented / a PR. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants