-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should document the exact minimum versions of build tools required to build a given Rust toolchain #129307
Comments
I think this makes sense, but it should be noted that just documenting is very likely to get accidentally stale. Unfortunately, it's not clear that we can easily test those in CI -- often the minimum requires a good deal of work to actually obtain, especially on e.g. macOS or Windows. |
We'd probably have to have a tier system similar to platform support:
|
This is already happening with the min VS version: If we're going to document tooling versions, then it really needs to be in a single place that everything else references, and we need to have pointers between the code and those docs to ensure that things are updated together. |
I've put together some thoughts about this into a Pre-RFC: https://internals.rust-lang.org/t/pre-rfc-build-tool-support-policy-aka-tool-tier-policy/21596 |
We probably need to bump |
@tgross35 I'm not sure there needs to be anything changed in Rust's docs: Once rustup deploys their new docs there will be nothing left that indicates that VS 2013 (or 2015) is supported. |
`cc` was previously pinned because it dropped support for Visual Studio 12 (2013), and we wanted to decouple that from the rest of the automated updates. As noted in [2], there is no longer anything indicating we support VS2013, so it should be okay to unpin it. `cc` 1.1.22 contains a fix that may help improve the high MSVC CI failure rate [3], so we also have motivation to update to that point. [1]: rust-lang#129307 [2]: rust-lang#129307 (comment) [3]: rust-lang#127883
`cc` was previously pinned because version 1.1.106 dropped support for Visual Studio 12 (2013), and we wanted to decouple that from the rest of the automated updates. As noted in [2], there is no longer anything indicating we support VS2013, so it should be okay to unpin it. `cc` 1.1.22 contains a fix that may help improve the high MSVC CI failure rate [3], so we also have motivation to update to that point. [1]: rust-lang#129307 [2]: rust-lang#129307 (comment) [3]: rust-lang#127883
Oh, thanks for confirming - opened #131070 to bump We should still figure out a good policy here, so it makes sense to leave this issue open. |
Unpin `cc` and upgrade to the latest version `cc` was previously pinned because 1.1.106 dropped support for Visual Studio 12 (2013), and we wanted to decouple that from the rest of the automated updates. As noted in [2], there is no longer anything indicating we support VS2013, so it should be okay to unpin it. `cc` 1.1.22 contains a fix that may help improve the high MSVC CI failure rate [3], so we also have motivation to update to that point. [1]: rust-lang#129307 [2]: rust-lang#129307 (comment) [3]: rust-lang#127883 try-job: x86_64-msvc-ext
Unpin `cc` and upgrade to the latest version `cc` was previously pinned because 1.1.106 dropped support for Visual Studio 12 (2013), and we wanted to decouple that from the rest of the automated updates. As noted in [2], there is no longer anything indicating we support VS2013, so it should be okay to unpin it. `cc` 1.1.22 contains a fix that may help improve the high MSVC CI failure rate [3], so we also have motivation to update to that point. [1]: rust-lang#129307 [2]: rust-lang#129307 (comment) [3]: rust-lang#127883 try-job: x86_64-msvc-ext
As noticed in #128722 (comment) when trying to bump
cc
to a version which drops support for VS 2013.Also cc:
Originally posted by @ChrisDenton in #129290 (comment)
INSTALL.md
exists, but that seems more like some general advice for getting started, but not actual documented guarantees in terms of what kind of build environment is supported.The text was updated successfully, but these errors were encountered: